-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate 'preferences' e2e tests to Playwright #57446
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Pooja Killekar <[email protected]>
Mamaduka
added
the
[Type] Automated Testing
Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
label
Dec 29, 2023
Mamaduka
requested review from
kevin940726,
ntwb,
nerrad and
ajitbohra
as code owners
December 29, 2023 08:12
Mamaduka
changed the title
Migrate/preferences e2e tests
Migrate 'preferences' e2e tests to Playwright
Dec 29, 2023
Mamaduka
requested review from
WunderBart and
t-hamano
and removed request for
ntwb,
ajitbohra and
nerrad
December 29, 2023 08:13
Size Change: 0 B Total Size: 1.69 MB ℹ️ View Unchanged
|
t-hamano
approved these changes
Dec 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Type] Automated Testing
Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #38851.
Supersedes and closes #57443.
Why?
See ##38851.
How?
This is based on the initial migration work by @pooja-muchandikar - #57443.
Testing Instructions